Previous Thread
Next Thread
Print Thread
Page 3 of 4 1 2 3 4
#110795 - 09/15/17 09:45 AM Re: Generic bezel [Re: phulshof]  
Joined: Sep 2014
Posts: 80
phulshof Offline
Member
phulshof  Offline
Member

Joined: Sep 2014
Posts: 80
Netherlands
Proposal:
- If -override_artwork set: load override artwork, and return when successful
- Load explicit file, return when single file is set (UNCHANGED)
- Load driver name (UNCHANGED)
- Load internal default views (UNCHANGED)
- Load parent driver (UNCHANGED)
- Load parent of parent (will find neogeo for clone of neogeo games)
- If -fallback_artwork set: load fallback artwork
- For single screen: load internal horizont or vertical (UNCHANGED)
- If no layout has been found, load internal defaults based on number of screens (0, 2, 3, 4) (UNCHANGED)

#110796 - 09/15/17 01:59 PM Re: Generic bezel [Re: phulshof]  
Joined: Feb 2004
Posts: 1,874
Vas Crabb Offline
Very Senior Member
Vas Crabb  Offline
Very Senior Member

Joined: Feb 2004
Posts: 1,874
Sydney, Australia
Yeah, that would probably cover most cases.

#110797 - 09/15/17 02:57 PM Re: Generic bezel [Re: phulshof]  
Joined: Mar 2001
Posts: 15,775
R. Belmont Offline
R. Belmont  Offline

Very Senior Member

Joined: Mar 2001
Posts: 15,775
USA
I'd change:
- Load parent driver (UNCHANGED)
- Load parent of parent (will find neogeo for clone of neogeo games)

to:
- Load top-level parent driver or BIOS set

That's less KiddieGeo specific and will work better in cases of systems with BIOS sets.

#110798 - 09/15/17 03:31 PM Re: Generic bezel [Re: phulshof]  
Joined: Feb 2004
Posts: 1,874
Vas Crabb Offline
Very Senior Member
Vas Crabb  Offline
Very Senior Member

Joined: Feb 2004
Posts: 1,874
Sydney, Australia
That's effectively the same thing - BIOS set is implemented as parent-of-parent, you can only go two parents deep before you trigger a validation error.

#111359 - 11/24/17 08:55 AM Re: Generic bezel [Re: phulshof]  
Joined: Sep 2014
Posts: 80
phulshof Offline
Member
phulshof  Offline
Member

Joined: Sep 2014
Posts: 80
Netherlands
Ok, quick question: what's the best way to get this added to the MAME code? Should I fork the code, update it, and send a pull request? I'm not familiar with the way the MAME community works these days.

#111363 - 11/24/17 06:29 PM Re: Generic bezel [Re: phulshof]  
Joined: Oct 2006
Posts: 933
Stiletto Online content
Senior Member
Stiletto  Online Content
Senior Member

Joined: Oct 2006
Posts: 933
Originally Posted by phulshof
Ok, quick question: what's the best way to get this added to the MAME code? Should I fork the code, update it, and send a pull request? I'm not familiar with the way the MAME community works these days.


Yep, that is the best way. http://wiki.mamedev.org/index.php?title=Submitting_Source_Code

#111517 - 12/06/17 04:35 PM Re: Generic bezel [Re: phulshof]  
Joined: Sep 2014
Posts: 80
phulshof Offline
Member
phulshof  Offline
Member

Joined: Sep 2014
Posts: 80
Netherlands
Ok, I think I've got something ready. Since this is my first time on the MAME project, is anyone willing to have a look at it, and perhaps give it a go?

#111522 - 12/06/17 10:41 PM Re: Generic bezel [Re: phulshof]  
Joined: Feb 2004
Posts: 1,874
Vas Crabb Offline
Very Senior Member
Vas Crabb  Offline
Very Senior Member

Joined: Feb 2004
Posts: 1,874
Sydney, Australia
Have you made a pull request we can look at?

#111527 - 12/07/17 09:41 AM Re: Generic bezel [Re: Vas Crabb]  
Joined: Sep 2014
Posts: 80
phulshof Offline
Member
phulshof  Offline
Member

Joined: Sep 2014
Posts: 80
Netherlands
Originally Posted by Vas Crabb
Have you made a pull request we can look at?


No, not yet. Since this is to be my first contribution I figure I'd want someone to look at the code first before dirtying the check-in log with changes I need to do based on feedback. I've tried to maintain the coding style, and use the functions I could find, but it's not unlikely that some things might be done in a simpler way using functions I'm not aware of. If it's your preference though, I could check the code into github, and do a pull request in stead.

#111528 - 12/07/17 10:58 AM Re: Generic bezel [Re: phulshof]  
Joined: Apr 2005
Posts: 537
Darkstar Offline
Senior Member
Darkstar  Offline
Senior Member

Joined: Apr 2005
Posts: 537
GERMANY
Usually things like coding style etc. can be addressed after the pull request has been made. You can update it or cancel it and do a fresh one, everyone can look at it and comment on it, etc.

Page 3 of 4 1 2 3 4

Who's Online Now
7 registered members (box, ted, F1ReB4LL, Cpt. Pugwash, r09, Pernod, AJR), 21 guests, and 3 spiders.
Key: Admin, Global Mod, Mod
Shout Box
Forum Statistics
Forums9
Topics8,456
Posts109,747
Members4,768
Most Online225
May 26th, 2014
Powered by UBB.threads™ PHP Forum Software 7.6.0
Page Time: 0.069s Queries: 15 (0.032s) Memory: 5.0184 MB (Peak: 5.2673 MB) Zlib enabled. Server Time: 2017-12-15 21:18:37 UTC