Previous Thread
Next Thread
Print Thread
Page 6 of 7 1 2 3 4 5 6 7
#103098 - 12/19/15 12:00 AM Re: New build instructions for SDLMAME on Mac OS X [Re: MAMEBase]  
Joined: Dec 2015
Posts: 48
AJR Offline
Member
AJR  Offline
Member

Joined: Dec 2015
Posts: 48
I have found that following the instructions strictly, and placing everything in directory named MAME Parts, gives ample space for error, as GENIE will be led into monstrous errors of slash fiction(al directories). But I have come to a conclusion from which there is no escape: the fault lies not in our third-party libraries, but in our scripts. (All puns intentional.)

#103099 - 12/19/15 01:42 AM Re: New build instructions for SDLMAME on Mac OS X [Re: MAMEBase]  
Joined: Mar 2001
Posts: 15,707
R. Belmont Offline
R. Belmont  Offline

Very Senior Member

Joined: Mar 2001
Posts: 15,707
USA
And we accept pull requests any time at http://github.org/mamedev/mame/

#103100 - 12/19/15 03:52 AM Re: New build instructions for SDLMAME on Mac OS X [Re: MAMEBase]  
Joined: Dec 2015
Posts: 48
AJR Offline
Member
AJR  Offline
Member

Joined: Dec 2015
Posts: 48
I spoke too soon about the problem not being with GENIE. SDLMAME might have to discontinue automatic inclusion of src/osd/sdl/sdlprefix.h for the moment because of a stupid GENIE bug which applies the wrong type of escaping (HTML rather than shell) to FORCE_INCLUDE paths.

Should I just leave the first few lines of code in scripts/src/osd/sdl_cfg.lua commented out? (The defines seem to be doing the same thing as sdlprefix.h, at least for OS X.) Should I try to re-include sdlprefix.h by some currently less broken way? Should I make modifications in 3rdparty/genie/src, or is that sort of thing not supposed to be done? (I have already submitted them to the GENIE project as a pull request.)

Last edited by AJR; 12/19/15 05:39 AM. Reason: Asking for directions
#103105 - 12/19/15 12:43 PM Re: New build instructions for SDLMAME on Mac OS X [Re: MAMEBase]  
Joined: Feb 2004
Posts: 1,826
Vas Crabb Offline
Very Senior Member
Vas Crabb  Offline
Very Senior Member

Joined: Feb 2004
Posts: 1,826
Sydney, Australia
We have a great relationship with Branimir, and he generally accepts patches to bgfx and GENie from Micko and me. How about submitting a patch to fix the problem in GENie if you're sure that's where it is?

#103107 - 12/19/15 01:36 PM Re: New build instructions for SDLMAME on Mac OS X [Re: MAMEBase]  
Joined: Mar 2001
Posts: 15,707
R. Belmont Offline
R. Belmont  Offline

Very Senior Member

Joined: Mar 2001
Posts: 15,707
USA
I'm... not understanding what the problem is. I can build beautifully on OS X, including sdlprefix.h, and I believe Vas can too. Are you trying to build on 10.4 or something?

ETA: Oh, I get it. You're building from a directory with a space in it. That doesn't even work on Windows. Stop doing it.

Last edited by R. Belmont; 12/19/15 01:40 PM.
#103111 - 12/19/15 04:25 PM Re: New build instructions for SDLMAME on Mac OS X [Re: MAMEBase]  
Joined: Dec 2015
Posts: 48
AJR Offline
Member
AJR  Offline
Member

Joined: Dec 2015
Posts: 48
Quote:

Oh, I get it. You're building from a directory with a space in it. That doesn't even work on Windows. Stop doing it.


"Doctor, it hurts when I do this." "Well, don't do that, then!" I may be no medical expert, but in this case I know I can do better than that. Anyway, it works now that I've fixed it, and I've submitted the pull request. Since the GENie license does allow modifications, I decided to apply the same patch I submitted to the GENie project, which means that sdl_cfg.lua can stay exactly as it was.

#103112 - 12/19/15 05:42 PM Re: New build instructions for SDLMAME on Mac OS X [Re: MAMEBase]  
Joined: Mar 2001
Posts: 15,707
R. Belmont Offline
R. Belmont  Offline

Very Senior Member

Joined: Mar 2001
Posts: 15,707
USA
Yeah, that's exactly the joke I was headed for smile Glad to hear you were able to resolve the issue at the right level.

#103119 - 12/19/15 11:43 PM Re: New build instructions for SDLMAME on Mac OS X [Re: MAMEBase]  
Joined: Mar 2001
Posts: 15,707
R. Belmont Offline
R. Belmont  Offline

Very Senior Member

Joined: Mar 2001
Posts: 15,707
USA
...and you broke the all-important SOURCES= tiny build option. Ouch!

Test case: "make clean; make SOURCES=src/mame/drivers/namcos23.cpp REGENIE=1 -j3". The wrong parameters are passed to makedep.py.

I've reverted your changes in MAME to unblock people working on stuff; please resubmit when you've fixed the problem.

Last edited by R. Belmont; 12/19/15 11:57 PM.
#103121 - 12/20/15 01:44 AM Re: New build instructions for SDLMAME on Mac OS X [Re: MAMEBase]  
Joined: Dec 2015
Posts: 48
AJR Offline
Member
AJR  Offline
Member

Joined: Dec 2015
Posts: 48
I figured out what was breaking makedep.py in the SOURCES build (which is, of course, handled completely differently from the tiny subtarget). The calls to _MAKE.esc are still in order, but some arguments just need to keep their .. " " .. from each other.

#103122 - 12/20/15 01:49 AM Re: New build instructions for SDLMAME on Mac OS X [Re: MAMEBase]  
Joined: Mar 2001
Posts: 15,707
R. Belmont Offline
R. Belmont  Offline

Very Senior Member

Joined: Mar 2001
Posts: 15,707
USA
Great! In the future, please put functionally unrelated changes in separate requests though; now we can't put the Genie fixes back until we find out if you've violated Olivier's architectural direction for the memory system.

Page 6 of 7 1 2 3 4 5 6 7

Moderated by  R. Belmont 

Who's Online Now
1 registered members (1 invisible), 13 guests, and 3 spiders.
Key: Admin, Global Mod, Mod
Shout Box
Forum Statistics
Forums9
Topics8,411
Posts108,909
Members4,757
Most Online225
May 26th, 2014
Powered by UBB.threads™ PHP Forum Software 7.6.0
Page Time: 0.062s Queries: 14 (0.034s) Memory: 5.0241 MB (Peak: 5.2538 MB) Zlib enabled. Server Time: 2017-09-21 22:51:19 UTC