Previous Thread
Next Thread
Print Thread
Page 4 of 4 1 2 3 4
#111529 - 12/07/17 12:58 PM Re: Generic bezel [Re: phulshof]  
Joined: Mar 2001
Posts: 15,775
R. Belmont Offline
R. Belmont  Offline

Very Senior Member

Joined: Mar 2001
Posts: 15,775
USA
It's not dirtying, that's what pull requests are for smile

#111547 - 12/08/17 08:02 AM Re: Generic bezel [Re: R. Belmont]  
Joined: Sep 2014
Posts: 81
phulshof Online content
Member
phulshof  Online Content
Member

Joined: Sep 2014
Posts: 81
Netherlands
Ok, the pull request has been generated. Feel free to let me know how I can improve my work. smile

#111609 - 12/11/17 07:25 PM Re: Generic bezel [Re: phulshof]  
Joined: Sep 2014
Posts: 81
phulshof Online content
Member
phulshof  Online Content
Member

Joined: Sep 2014
Posts: 81
Netherlands
Should games for which an internal layout has been defined be able to use fallback artwork? In other words, should fallback artwork be loaded if:
1. No artwork has been found.
2. No artwork other than an internal layout has been found?

#111620 - 12/12/17 01:54 PM Re: Generic bezel [Re: phulshof]  
Joined: Feb 2004
Posts: 1,874
Vas Crabb Offline
Very Senior Member
Vas Crabb  Offline
Very Senior Member

Joined: Feb 2004
Posts: 1,874
Sydney, Australia
If internal artwork is defined, fallback artwork should at most generate additional views, not completely replace the internal artwork. Otherwise something like intlc440 will become unusable since it depends heavily on the clickable switches and blinkenlights. If the user can't select one of the views from the internal when they have fallback artwork set, it will just lead to frustration.

#111621 - 12/12/17 04:44 PM Re: Generic bezel [Re: Vas Crabb]  
Joined: Sep 2014
Posts: 81
phulshof Online content
Member
phulshof  Online Content
Member

Joined: Sep 2014
Posts: 81
Netherlands
Originally Posted by Vas Crabb
If internal artwork is defined, fallback artwork should at most generate additional views, not completely replace the internal artwork. Otherwise something like intlc440 will become unusable since it depends heavily on the clickable switches and blinkenlights. If the user can't select one of the views from the internal when they have fallback artwork set, it will just lead to frustration.


That's clear, and already implemented as internal artwork has preference over fallback artwork. I will change the code to only load fallback artwork when no artwork other than internal artwork has been found. I'll have a look at how to update a pull request or drop the current one, and create a new one otherwise.

#111622 - 12/12/17 05:57 PM Re: Generic bezel [Re: phulshof]  
Joined: Sep 2014
Posts: 81
phulshof Online content
Member
phulshof  Online Content
Member

Joined: Sep 2014
Posts: 81
Netherlands
Another quick question: In the current code, built-in layouts are not loaded for 0 and 2 screens when artwork has already been found, but are loaded for 1 and >= 3 screens. Why is that exactly?

#111626 - 12/13/17 01:44 PM Re: Generic bezel [Re: phulshof]  
Joined: Feb 2004
Posts: 1,874
Vas Crabb Offline
Very Senior Member
Vas Crabb  Offline
Very Senior Member

Joined: Feb 2004
Posts: 1,874
Sydney, Australia
Well, for 0 screens, the built-in artwork is just a big message saying that no screens were found, so there's no point loading it if any other viable views are present. The main reason for adding the programmatically-generated views was to make MAME do something useful (i.e. not crash) when a system was configured to have four or more screens, and it was easier to just pretend the two-screen case didn't exist to get the high screen numbers working. I do want to revisit the two-screen case some time, but day job is busting my balls at the moment.

#111627 - 12/13/17 02:28 PM Re: Generic bezel [Re: phulshof]  
Joined: Sep 2014
Posts: 81
phulshof Online content
Member
phulshof  Online Content
Member

Joined: Sep 2014
Posts: 81
Netherlands
Fair enough; I'll leave that part as is then, and run some more tests before checking in my updated code.

#111673 - 12/16/17 08:32 PM Re: Generic bezel [Re: phulshof]  
Joined: Sep 2014
Posts: 81
phulshof Online content
Member
phulshof  Online Content
Member

Joined: Sep 2014
Posts: 81
Netherlands
Code and pull request have been updated. Please let me know if you need additional changes. smile

Page 4 of 4 1 2 3 4

Who's Online Now
3 registered members (Breiztiger, phulshof, 1 invisible), 19 guests, and 3 spiders.
Key: Admin, Global Mod, Mod
Shout Box
Forum Statistics
Forums9
Topics8,457
Posts109,760
Members4,768
Most Online225
May 26th, 2014
Powered by UBB.threads™ PHP Forum Software 7.6.0
Page Time: 0.036s Queries: 16 (0.011s) Memory: 5.0068 MB (Peak: 5.2265 MB) Zlib enabled. Server Time: 2017-12-16 20:39:08 UTC