Previous Thread
Next Thread
Print Thread
Page 2 of 4 1 2 3 4
Joined: May 2009
Posts: 2,023
Likes: 59
J
Very Senior Member
OP Offline
Very Senior Member
J
Joined: May 2009
Posts: 2,023
Likes: 59
I think that n64.c should become some minimal shell, which calls out to mame/video/n64/vi.c and mame/video/n64/rdp/rdp*.c. Aaron will have kittens at the thought of adding subdirectories to the beautiful, 1998-esque flat directory structure, but if he does I'll try to shout him down, because this is the first instance that really needs it. smile

Joined: Oct 2006
Posts: 1,015
Likes: 21
S
Very Senior Member
Offline
Very Senior Member
S
Joined: Oct 2006
Posts: 1,015
Likes: 21
Honestly, I've never heard that come up for debate in the many years I've had access to the list. However, what's the number of options for the *? smile

Joined: May 2009
Posts: 2,023
Likes: 59
J
Very Senior Member
OP Offline
Very Senior Member
J
Joined: May 2009
Posts: 2,023
Likes: 59
Based on the current codebase:

rdpfb.c
rdpspn16.c
rdpblend.c
rdpfetch.c
rdptrect.c
rdpfrect.c
rdptpipe.c
Maybe others that I can't remember

Joined: Jan 2006
Posts: 3,690
Very Senior Member
Offline
Very Senior Member
Joined: Jan 2006
Posts: 3,690
fwiw, I disagree on adding subdirectory to the tree. you can order files by names and they end up close each to the other...

Joined: May 2009
Posts: 2,023
Likes: 59
J
Very Senior Member
OP Offline
Very Senior Member
J
Joined: May 2009
Posts: 2,023
Likes: 59
Originally Posted By etabeta78
fwiw, I disagree on adding subdirectory to the tree. you can order files by names and they end up close each to the other...


That's not a good reason at all. By your logic we should just do away with all subdirectories entirely, and rename rsp.c to srcemucpursprsp.c. But we don't, because groups of files with similar functionality are grouped into subdirectories. Anyway, what do you care what I do with my code?

Joined: Sep 2009
Posts: 84
M
Member
Offline
Member
M
Joined: Sep 2009
Posts: 84
Hmmm N64 Emulation is broken again? i was tested goldeneye rom and i have bugged screen, and mario 64 crash again.

Joined: Apr 2010
Posts: 57
H
Member
Offline
Member
H
Joined: Apr 2010
Posts: 57
If a subdirectory would avoid names that look like a compiler's name mangling schemes, I think it would be a good thing, for the same reason that being able to refer within your code to a function with a name that only requires one breath to pronounce is a good thing. However, my initial concern here is finding a few more details on the logical subdivisions between the existing directories in the source tree.

In the N64, the RDP handles graphics command lists and writes resulting pixels back to main memory, which is accessible by other processors, the RSP and the MIPS r4300. On the other hand the VI, video interface, is responsible for reading the framebuffer from main memory, resampling those pixels and providing an output in NTSC or PAL format to your television. The VI doesn't write anything back to memory. Only the television screen shows the efforts of the VI.

My question is if mess/video is for those components which interface between the framebuffer and the television screen or if other components like the RDP belong there as well. The same decision would apply to sound hardware and the audio directory as well. Should a DSP which calculates filters and writes a buffer back into memory be in the audio directory or should the audio directory only be concerned with components that directly interface to the speaker? I'm sure there are plenty of examples of components that don't easily categorize according to this scheme, but with respect to the N64, the RDP and the VI, I was wondering if this complies with the intentions of the existing directory structure.

Joined: Mar 2001
Posts: 16,892
Likes: 51
R
Very Senior Member
Offline
Very Senior Member
R
Joined: Mar 2001
Posts: 16,892
Likes: 51
I don't think the RDP needs to be as many files as it is, and it absolutely does not merit it's own directory.

And Happy seems intent on talking the RDP and VI to death. It's real simple: everything involved in a system's video emulation that isn't a CPU goes in video/ and everything involved in audio that isn't a CPU goes in audio/. For the N64, the RDP and VI both go in video/ and the AI would go in audio/ if it weren't about 50 lines of code.

Last edited by R. Belmont; 04/14/10 06:37 PM.
Joined: Jan 2006
Posts: 3,690
Very Senior Member
Offline
Very Senior Member
Joined: Jan 2006
Posts: 3,690
also, the proper location would be mame/video not mess/video since the component are used also by Aleck64 games in MAME wink

Joined: May 2009
Posts: 2,023
Likes: 59
J
Very Senior Member
OP Offline
Very Senior Member
J
Joined: May 2009
Posts: 2,023
Likes: 59
Originally Posted By R. Belmont
I don't think the RDP needs to be as many files as it is, and it absolutely does not merit it's own directory.


You're right, one single header with a damn cornucopia of classes and a single source file with thousands of lines in it is so much better. Man, you just relinquished any rights you had to complain about my coding style.

Edit: I've said it before and I'll say it again: All of you need to get the hell off my case with regard to how I write my drivers. Pay my salary if you want to dictate how I write my code, but if you don't feel like doing that, fuck off.

Page 2 of 4 1 2 3 4

Link Copied to Clipboard
Who's Online Now
2 members (MAMEBase, Carbon), 12 guests, and 2 robots.
Key: Admin, Global Mod, Mod
ShoutChat
Comment Guidelines: Do post respectful and insightful comments. Don't flame, hate, spam.
Forum Statistics
Forums9
Topics9,070
Posts118,935
Members5,014
Most Online890
Jan 17th, 2020
Our Sponsor
These forums are sponsored by Superior Solitaire, an ad-free card game collection for macOS and iOS. Download it today!

Superior Solitaire
Forum hosted by www.retrogamesformac.com