Previous Thread
Next Thread
Print Thread
Page 6 of 8 1 2 3 4 5 6 7 8
Joined: Dec 2015
Posts: 143
Likes: 2
A
AJR Online Content
Senior Member
Online Content
Senior Member
A
Joined: Dec 2015
Posts: 143
Likes: 2
I have found that following the instructions strictly, and placing everything in directory named MAME Parts, gives ample space for error, as GENIE will be led into monstrous errors of slash fiction(al directories). But I have come to a conclusion from which there is no escape: the fault lies not in our third-party libraries, but in our scripts. (All puns intentional.)

Joined: Mar 2001
Posts: 16,840
Likes: 45
R
Very Senior Member
Offline
Very Senior Member
R
Joined: Mar 2001
Posts: 16,840
Likes: 45
And we accept pull requests any time at http://github.org/mamedev/mame/

Joined: Dec 2015
Posts: 143
Likes: 2
A
AJR Online Content
Senior Member
Online Content
Senior Member
A
Joined: Dec 2015
Posts: 143
Likes: 2
I spoke too soon about the problem not being with GENIE. SDLMAME might have to discontinue automatic inclusion of src/osd/sdl/sdlprefix.h for the moment because of a stupid GENIE bug which applies the wrong type of escaping (HTML rather than shell) to FORCE_INCLUDE paths.

Should I just leave the first few lines of code in scripts/src/osd/sdl_cfg.lua commented out? (The defines seem to be doing the same thing as sdlprefix.h, at least for OS X.) Should I try to re-include sdlprefix.h by some currently less broken way? Should I make modifications in 3rdparty/genie/src, or is that sort of thing not supposed to be done? (I have already submitted them to the GENIE project as a pull request.)

Last edited by AJR; 12/19/15 05:39 AM. Reason: Asking for directions
Joined: Feb 2004
Posts: 2,290
Likes: 19
Very Senior Member
Offline
Very Senior Member
Joined: Feb 2004
Posts: 2,290
Likes: 19
We have a great relationship with Branimir, and he generally accepts patches to bgfx and GENie from Micko and me. How about submitting a patch to fix the problem in GENie if you're sure that's where it is?

Joined: Mar 2001
Posts: 16,840
Likes: 45
R
Very Senior Member
Offline
Very Senior Member
R
Joined: Mar 2001
Posts: 16,840
Likes: 45
I'm... not understanding what the problem is. I can build beautifully on OS X, including sdlprefix.h, and I believe Vas can too. Are you trying to build on 10.4 or something?

ETA: Oh, I get it. You're building from a directory with a space in it. That doesn't even work on Windows. Stop doing it.

Last edited by R. Belmont; 12/19/15 01:40 PM.
Joined: Dec 2015
Posts: 143
Likes: 2
A
AJR Online Content
Senior Member
Online Content
Senior Member
A
Joined: Dec 2015
Posts: 143
Likes: 2
Quote:

Oh, I get it. You're building from a directory with a space in it. That doesn't even work on Windows. Stop doing it.


"Doctor, it hurts when I do this." "Well, don't do that, then!" I may be no medical expert, but in this case I know I can do better than that. Anyway, it works now that I've fixed it, and I've submitted the pull request. Since the GENie license does allow modifications, I decided to apply the same patch I submitted to the GENie project, which means that sdl_cfg.lua can stay exactly as it was.

Joined: Mar 2001
Posts: 16,840
Likes: 45
R
Very Senior Member
Offline
Very Senior Member
R
Joined: Mar 2001
Posts: 16,840
Likes: 45
Yeah, that's exactly the joke I was headed for smile Glad to hear you were able to resolve the issue at the right level.

Joined: Mar 2001
Posts: 16,840
Likes: 45
R
Very Senior Member
Offline
Very Senior Member
R
Joined: Mar 2001
Posts: 16,840
Likes: 45
...and you broke the all-important SOURCES= tiny build option. Ouch!

Test case: "make clean; make SOURCES=src/mame/drivers/namcos23.cpp REGENIE=1 -j3". The wrong parameters are passed to makedep.py.

I've reverted your changes in MAME to unblock people working on stuff; please resubmit when you've fixed the problem.

Last edited by R. Belmont; 12/19/15 11:57 PM.
Joined: Dec 2015
Posts: 143
Likes: 2
A
AJR Online Content
Senior Member
Online Content
Senior Member
A
Joined: Dec 2015
Posts: 143
Likes: 2
I figured out what was breaking makedep.py in the SOURCES build (which is, of course, handled completely differently from the tiny subtarget). The calls to _MAKE.esc are still in order, but some arguments just need to keep their .. " " .. from each other.

Joined: Mar 2001
Posts: 16,840
Likes: 45
R
Very Senior Member
Offline
Very Senior Member
R
Joined: Mar 2001
Posts: 16,840
Likes: 45
Great! In the future, please put functionally unrelated changes in separate requests though; now we can't put the Genie fixes back until we find out if you've violated Olivier's architectural direction for the memory system.

Page 6 of 8 1 2 3 4 5 6 7 8

Moderated by  R. Belmont 

Link Copied to Clipboard
Who's Online Now
4 members (Dorando, Dullaron, Bletch, 1 invisible), 26 guests, and 3 robots.
Key: Admin, Global Mod, Mod
ShoutChat
Comment Guidelines: Do post respectful and insightful comments. Don't flame, hate, spam.
Forum Statistics
Forums9
Topics8,992
Posts118,145
Members5,005
Most Online890
Jan 17th, 2020
Forum Host
These forums are hosted by www.retrogamesformac.com
Forum hosted by www.retrogamesformac.com