Previous Thread
Next Thread
Print Thread
Page 16 of 55 1 2 14 15 16 17 18 54 55
Re: AO SDK release 1.3.2 available [Re: R. Belmont] #38308 02/13/08 04:45 AM
Joined: Sep 2007
Posts: 56
K
kingshriek Offline
Member
Offline
Member
K
Joined: Sep 2007
Posts: 56
R. Belmont: I haven't done anything with the AICA since my last patch, so feel free to work on it.

I do have a (preliminary) Gunbird 2 rip, though, in case anyone is interested. I'm not sure if the rip is correct, however, since IMXL/ISEL/DISDL/DIPAN are constant (0/0/F/0) for all key-ons which would indicate the game's music is mono (can this actually be the case?). I went ahead and ripped all sequences (MSB) and one-shot banks (OSB). Interestingly, Highly Theoretical fails to play any of the OSB tracks, but AOSDK handles them just fine.

http://www.sendspace.com/file/evlrsa

Re: AO SDK release 1.3.2 available [Re: kingshriek] #38309 02/13/08 05:01 AM
Joined: Mar 2001
Posts: 16,389
R
R. Belmont Online Content OP
Very Senior Member
OP Online Content
Very Senior Member
R
Joined: Mar 2001
Posts: 16,389
The arcade Gunbird 2 appears to be mono too, even though it's sequenced on a chip that's quite capable of good stereo (YMF278B, which is essentially the SCSP's father).

Re: AO SDK release 1.3.2 available [Re: R. Belmont] #38338 02/14/08 03:29 AM
Joined: Mar 2001
Posts: 16,389
R
R. Belmont Online Content OP
Very Senior Member
OP Online Content
Very Senior Member
R
Joined: Mar 2001
Posts: 16,389
Mmm, nice. Doing type 2 as DK suggests does improve things quite a bit. Gonna try and get interpolation going with ADPCM now.

Re: AO SDK release 1.3.2 available [Re: R. Belmont] #38343 02/14/08 05:14 AM
Joined: Mar 2001
Posts: 16,389
R
R. Belmont Online Content OP
Very Senior Member
OP Online Content
Very Senior Member
R
Joined: Mar 2001
Posts: 16,389
New SDK:

http://rbelmont.mameworld.info/aosdk_140a5.zip

- Fixed ADPCM looping as per Deunan. Sakura Taisen 4 is distortion-free now, but ST3 still has some (possibly due to other causes?)
- I tried to get ADPCM interpolation going. And failed smirk
- Fixed some Skies of Arcadia songs from crashing - they were setting an active slot playing 16-bit samples' control register so that PCMS = 2, and thus adbase was NULL. Not sure exactly what real h/w would do here since neither KEYONEX or KEYONB are set in the new CTRL value.
- Ideas welcome on whatever we're still missing, notably the filter.

Re: AO SDK release 1.3.2 available [Re: R. Belmont] #38346 02/14/08 05:33 AM
Joined: Sep 2007
Posts: 56
K
kingshriek Offline
Member
Offline
Member
K
Joined: Sep 2007
Posts: 56
Originally Posted By R. Belmont

- I tried to get ADPCM interpolation going. And failed smirk


Code:
diff -Nru aosdk_base/eng_dsf/aica.c aosdk/eng_dsf/aica.c
--- aosdk_base/eng_dsf/aica.c	2008-02-14 00:03:50.000000000 -0800
+++ aosdk/eng_dsf/aica.c	2008-02-13 21:30:06.000000000 -0800
@@ -1037,15 +1037,14 @@
 			slot->nxtbase = base;
 			slot->nxtstep = curstep;
 
-			s=(slot->cur_sample);
-	//		s=(int) slot->cur_sample*((1<<SHIFT)-fpart)+(int) slot->nxt_sample*fpart;
+			s=(int) slot->cur_sample*((1<<SHIFT)-fpart)+(int) slot->nxt_sample*fpart;
 		}
 		else
 		{
 			s = 0;
 		}
 
-		sample=s;
+		sample=s>>SHIFT;
 	}
 	
 	slot->prv_addr=slot->cur_addr;


Re: AO SDK release 1.3.2 available [Re: kingshriek] #38348 02/14/08 05:56 AM
Joined: Mar 2001
Posts: 16,389
R
R. Belmont Online Content OP
Very Senior Member
OP Online Content
Very Senior Member
R
Joined: Mar 2001
Posts: 16,389
And this is why I shouldn't work on code at midnight. Thanks, ks smile

Re: AO SDK release 1.3.2 available [Re: R. Belmont] #38358 02/14/08 01:01 PM
Joined: Feb 2008
Posts: 107
D
Deunan Knute Offline
Senior Member
Offline
Senior Member
D
Joined: Feb 2008
Posts: 107
Hmm... so basically you keep two ADPCM states per channel, one for main sample and one for interpolation? Interesting.
There's a limit on pitch changes (vs sound's own) when it comes to ADPCM, but what happens if you're standing on LEA-1 and steps_to_go is greater than 1, say 2 for example? Won't it read LEA-1 (correct) and then LEA sample/garbage (that's past loop end now) and contaminate decoder state? This is a very rare case, but still...

I don't know what happens when you change sample type on active channel - I could try to test that. I'm kinda busy now, away from home/town much, so it will have to wait a bit on the TO-DO list.
My code will happily switch but ADPCM state will be undefined as it's preset on KEY ON. What AEG phase/level was that channel when the switch happened?

If there are any channels playing ADPCM wrong, try to catch what sample type it is (2/3) and what are LSA and LEA. I can't find good test cases where LSA > 0.

Re: AO SDK release 1.3.2 available [Re: Deunan Knute] #38361 02/14/08 02:05 PM
Joined: Mar 2001
Posts: 16,389
R
R. Belmont Online Content OP
Very Senior Member
OP Online Content
Very Senior Member
R
Joined: Mar 2001
Posts: 16,389
a5 with kingshriek's fix:

http://rbelmont.mameworld.info/aosdk_140a5a.zip

Sounds very nice. I could listen to Skies of Arcadia all day on it now :-)

BTW, KS, how are we doing vs. HE on the problems you were having with some of your rips?

PS: I'll post new AO builds with DSF support later today. Richard, if you want to get a head start, just use the eng_dsf from the aosdk.

Re: AO SDK release 1.3.2 available [Re: R. Belmont] #38375 02/14/08 07:22 PM
Joined: Dec 1969
Posts: 896
Richard Bannister Offline
Senior Member
Offline
Senior Member
Joined: Dec 1969
Posts: 896
Hmmm... sounds a little screwy on my machine. Has this been de-endianed yet?


Noli umquam docere porcum cantare; perdes tempus et irritabis porcum.
Re: AO SDK release 1.3.2 available [Re: Richard Bannister] #38376 02/14/08 07:33 PM
Joined: Mar 2001
Posts: 16,389
R
R. Belmont Online Content OP
Very Senior Member
OP Online Content
Very Senior Member
R
Joined: Mar 2001
Posts: 16,389
The 16-bit samples may need to be de-endianed. I can't think of anywhere else that should be a problem though.

Page 16 of 55 1 2 14 15 16 17 18 54 55

Moderated by  R. Belmont, Richard Bannister 

Who's Online Now
3 registered members (JonasP, AJR, rfka01), 171 guests, and 1 spider.
Key: Admin, Global Mod, Mod
ShoutChat Box
Comment Guidelines: Do post respectful and insightful comments. Don't flame, hate, spam.
Forum Statistics
Forums9
Topics8,721
Posts114,624
Members4,873
Most Online510
Aug 26th, 2019
Powered by UBB.threads™ PHP Forum Software 7.7.3