Home Page Forums MAME MAME SVN builds - new driver flood

Concerning r6388, I think video_filter16 should look like this:
INT32 leftuppix = - hres - 2;//not -4 now, it's in pixels now, not bytes
//and so on
...
INT32 leftupcvg = - hres - 2;//still -2
...
pix = vbuff[leftuppix ^ WORD_ADDR_XOR];
cvg = hbuff[leftupcvg ^ BYTE_ADDR_XOR] & 3;
...
leftupcvg++;//these two may be merged now
leftuppix++;

Concerning r6387, haven't we already determined that these registers are 24-bit wide?

I don't know, why don't you hop onto IRC and talk to DrgnMndd about it? Not to disbelieve docs or anything like that, but r6387 was suggested by him based on behavior observed with real hardware.

Eta: Double post, please delete

Thanks goes to Yo_fr (the developer of the MESS driver) to send me a .wav files for testing.
He made a tool to convert K7 to WAV format, maybe he can help to add in castool.

hector1 driver
Game : Formule 1 (Tape)





hec2hr/hec2hrp/hec2hrx/hec2mx40/hec2mx80 driver
Game : Stramble (High resolution, Tape)

On a 64-bit MSVC compile, most N64 games (e.g. Mario 64) crash immediately.

The crash appears to be in video_filter16, at the following line:
pix = vbuff[leftup ^ WORD_ADDR_XOR];

leftup is 0xfffffebe. WORD_ADDR_XOR is a macro so I can't easily debug what it's returning but maybe it's wrong on 64-bit?

EDIT: Hmm no, seems to be the same as on 32-bit, I guess leftup or vbuff is wrong somehow....

No, I'm pretty sure that leftup is plenty bad enough without having to look at WORD_ADDR_XOR as a culprit. Unfortunately, I don't have a 64-bit machine so that I can take a look myself.

leftup being negative is all manner of wrong without the xor, yes. Probably because almost no variables in the new N64 RDP code are initialized ever, sayeth GCC 4.

Well, given that hres is 320, and leftup is set to -hres - 2, I'm not sure what other result you can expect....

Me neither, but using a negative number as an array index is always wrong.