Previous Thread
Next Thread
Print Thread
Page 107 of 532 1 2 105 106 107 108 109 531 532
Re: SVN builds - new driver flood [Re: Just Desserts] #56344 11/15/09 11:24 AM
Joined: Sep 2007
Posts: 40
A
angrylion Offline
Member
Offline
Member
A
Joined: Sep 2007
Posts: 40
Concerning r6388, I think video_filter16 should look like this:
INT32 leftuppix = - hres - 2;//not -4 now, it's in pixels now, not bytes
//and so on
...
INT32 leftupcvg = - hres - 2;//still -2
...
pix = vbuff[leftuppix ^ WORD_ADDR_XOR];
cvg = hbuff[leftupcvg ^ BYTE_ADDR_XOR] & 3;
...
leftupcvg++;//these two may be merged now
leftuppix++;

Re: SVN builds - new driver flood [Re: angrylion] #56345 11/15/09 11:39 AM
Joined: Sep 2007
Posts: 40
A
angrylion Offline
Member
Offline
Member
A
Joined: Sep 2007
Posts: 40
Concerning r6387, haven't we already determined that these registers are 24-bit wide?

Re: SVN builds - new driver flood [Re: angrylion] #56346 11/15/09 11:40 AM
Joined: May 2009
Posts: 1,840
J
Just Desserts Offline
Very Senior Member
Offline
Very Senior Member
J
Joined: May 2009
Posts: 1,840
Originally Posted By angrylion
Concerning r6387, haven't we already determined that these registers are 24-bit wide?


I don't know, why don't you hop onto IRC and talk to DrgnMndd about it? Not to disbelieve docs or anything like that, but r6387 was suggested by him based on behavior observed with real hardware.

Re: SVN builds - new driver flood [Re: angrylion] #56347 11/15/09 11:41 AM
Joined: May 2009
Posts: 1,840
J
Just Desserts Offline
Very Senior Member
Offline
Very Senior Member
J
Joined: May 2009
Posts: 1,840
Eta: Double post, please delete

Re: SVN builds - new driver flood [Re: Anna Wu] #56348 11/15/09 01:04 PM
Joined: Jul 2007
Posts: 4,625
A
Anna Wu Offline OP
Very Senior Member
OP Offline
Very Senior Member
A
Joined: Jul 2007
Posts: 4,625
Originally Posted By Anna Wu
SVN r6350
Victor/Interact/Hector driver

Victor



Interact



Hector1



Hec2hrp



Hec2mx80



PS: I ask Daniel Coulom for a tool to convert .k7 to .wav format (tape). For the opposite way exist a tool.




Thanks goes to Yo_fr (the developer of the MESS driver) to send me a .wav files for testing.
He made a tool to convert K7 to WAV format, maybe he can help to add in castool.

hector1 driver
Game : Formule 1 (Tape)





hec2hr/hec2hrp/hec2hrx/hec2mx40/hec2mx80 driver
Game : Stramble (High resolution, Tape)



Last edited by Anna Wu; 11/15/09 02:58 PM.
Re: SVN builds - new driver flood [Re: Anna Wu] #56358 11/15/09 07:14 PM
Joined: Dec 1999
Posts: 1,175
J
Justin Offline
Very Senior Member
Offline
Very Senior Member
J
Joined: Dec 1999
Posts: 1,175
On a 64-bit MSVC compile, most N64 games (e.g. Mario 64) crash immediately.

The crash appears to be in video_filter16, at the following line:
pix = vbuff[leftup ^ WORD_ADDR_XOR];

leftup is 0xfffffebe. WORD_ADDR_XOR is a macro so I can't easily debug what it's returning but maybe it's wrong on 64-bit?

EDIT: Hmm no, seems to be the same as on 32-bit, I guess leftup or vbuff is wrong somehow....

Last edited by Justin; 11/15/09 07:37 PM.
Re: SVN builds - new driver flood [Re: Justin] #56359 11/15/09 07:33 PM
Joined: May 2009
Posts: 1,840
J
Just Desserts Offline
Very Senior Member
Offline
Very Senior Member
J
Joined: May 2009
Posts: 1,840
Originally Posted By Justin
leftup is 0xfffffebe. WORD_ADDR_XOR is a macro so I can't easily debug what it's returning but maybe it's wrong on 64-bit?


No, I'm pretty sure that leftup is plenty bad enough without having to look at WORD_ADDR_XOR as a culprit. Unfortunately, I don't have a 64-bit machine so that I can take a look myself.

Re: SVN builds - new driver flood [Re: Just Desserts] #56360 11/15/09 07:37 PM
Joined: Mar 2001
Posts: 16,473
R
R. Belmont Offline
Very Senior Member
Offline
Very Senior Member
R
Joined: Mar 2001
Posts: 16,473
leftup being negative is all manner of wrong without the xor, yes. Probably because almost no variables in the new N64 RDP code are initialized ever, sayeth GCC 4.

Last edited by R. Belmont; 11/15/09 07:37 PM.
Re: SVN builds - new driver flood [Re: R. Belmont] #56361 11/15/09 07:42 PM
Joined: Dec 1999
Posts: 1,175
J
Justin Offline
Very Senior Member
Offline
Very Senior Member
J
Joined: Dec 1999
Posts: 1,175
Well, given that hres is 320, and leftup is set to -hres - 2, I'm not sure what other result you can expect....

Re: SVN builds - new driver flood [Re: Justin] #56362 11/15/09 08:09 PM
Joined: Mar 2001
Posts: 16,473
R
R. Belmont Offline
Very Senior Member
Offline
Very Senior Member
R
Joined: Mar 2001
Posts: 16,473
Me neither, but using a negative number as an array index is always wrong.

Page 107 of 532 1 2 105 106 107 108 109 531 532

Who's Online Now
1 registered members (Fake Shemp), 111 guests, and 2 spiders.
Key: Admin, Global Mod, Mod
ShoutChat Box
Comment Guidelines: Do post respectful and insightful comments. Don't flame, hate, spam.
Forum Statistics
Forums9
Topics8,764
Posts115,182
Members4,889
Most Online890
Jan 17th, 2020
Powered by UBB.threads™ PHP Forum Software 7.7.3