|
Joined: May 2009
Posts: 2,214 Likes: 382
Very Senior Member
|
Very Senior Member
Joined: May 2009
Posts: 2,214 Likes: 382 |
Quick question: Should the condition in the if just before it:
/* add up the samples */
if (channelsamples > 0)
be changed to:
/* add up the samples */
if (chunksamples > 0)
Since channelsamples was changed to chunksamples in your diff on the line beneath it?
|
|
|
|
Joined: Sep 2009
Posts: 223
Senior Member
|
Senior Member
Joined: Sep 2009
Posts: 223 |
Very good question, and I think the answer is yes, which means that the "if" could just as well be deleted because chunksamples is always > 0.
|
|
|
|
Joined: May 2009
Posts: 2,214 Likes: 382
Very Senior Member
|
Very Senior Member
Joined: May 2009
Posts: 2,214 Likes: 382 |
Very good question, and I think the answer is yes, which means that the "if" could just as well be deleted because chunksamples is always > 0. In that case, it looks good to me. In other news, SVN r6449 should have all of the changes necessary for the SGI Indy driver (ip225015) to actually boot the Integrated Diagnostic Environment off of a CD (and promptly fail the diagnostics), or to boot sash (the SGI Stand-Alone Shell) and fx (the disc-partitioning tool), partition a blank HDD image, write out a valid boot sector, then boot up the IRIX 6.5 installer, at which point the installer bombs out. But still, progress.
|
|
|
|
Joined: Jul 2007
Posts: 4,625
Very Senior Member
|
OP
Very Senior Member
Joined: Jul 2007
Posts: 4,625 |
SVN r6447 " The Thompson artwork files are now zipped up. "
The artwork file called now " Thompson.zip " instead of " Thomson.zip ", is this right ?
Last edited by Anna Wu; 11/24/09 05:12 AM.
|
|
|
|
Joined: Aug 2004
Posts: 1,458 Likes: 9
Very Senior Member
|
Very Senior Member
Joined: Aug 2004
Posts: 1,458 Likes: 9 |
Oops, wrong filename. Fixed now.
Last edited by robbbert; 11/24/09 09:47 AM.
|
|
|
|
Joined: Jul 2007
Posts: 4,625
Very Senior Member
|
OP
Very Senior Member
Joined: Jul 2007
Posts: 4,625 |
Oops, wrong filename. Fixed now. Thanks, robbbert.
|
|
|
|
Joined: May 2009
Posts: 2,214 Likes: 382
Very Senior Member
|
Very Senior Member
Joined: May 2009
Posts: 2,214 Likes: 382 |
SVN r6472 adds sound to the Pocket Station driver.
|
|
|
|
Joined: Jul 2007
Posts: 4,625
Very Senior Member
|
OP
Very Senior Member
Joined: Jul 2007
Posts: 4,625 |
SVN (own build ) Sord M5 driver Game : Zac Banic (tape) and Solitaire (tape) + Basic-I (cartridge). Zac Banic, loaded with command " Tape " Solitaire, loaded with command " Chain "
Last edited by Anna Wu; 11/27/09 02:58 PM.
|
|
|
|
Joined: Sep 2009
Posts: 223
Senior Member
|
Senior Member
Joined: Sep 2009
Posts: 223 |
Very good question, and I think the answer is yes, which means that the "if" could just as well be deleted because chunksamples is always > 0. In that case, it looks good to me. I'd like to modify my previous answer. If you want correctly terminated audio streams it needs to be
/* add up the samples */
if (channelsamples > chunksamples)
file->info.audio_numsamples = stream->samples += chunksamples;
else if (channelsamples > 0)
file->info.audio_numsamples = stream->samples += channelsamples;
The previous code will count extra silence at the end of the audio stream, the amount depending on the wether you left in the original if or modified it / took it out.
|
|
|
|
Joined: May 2009
Posts: 2,214 Likes: 382
Very Senior Member
|
Very Senior Member
Joined: May 2009
Posts: 2,214 Likes: 382 |
SVN r6489: SGI IRIS 3130 IP2 driver
C:\mingw2\mess_latest>messd sgi_ip2 -r 640x480 -window -nonewui -nodebug -nolog
-nosound
►IRIS (IP2 - Revision E) Monitor Version 3.0.10 July 1, 1987
Unknown boot type 0x5
Power has been lost to the machine
iris> help
.:help: Error 0
iris> printenv
.:printenv: Error 0
iris> hinv
.:hinv: Error 0
iris> wank
.:wank: Error 0
iris> arse
.:arse: Error 0
iris> quit
.:quit: Error 0
iris> exit
PROMs exiting
►IRIS (IP2 - Revision E) Monitor Version 3.0.10 July 1, 1987
Unknown boot type 0x5
Power has been lost to the machine
iris> Average speed: 47.02% (14 seconds)
Wish I knew what "Error 0" meant, but it's a start.
|
|
|
Forums9
Topics9,320
Posts121,923
Members5,074
|
Most Online1,283 Dec 21st, 2022
|
|
These forums are sponsored by Superior Solitaire, an ad-free card game collection for macOS and iOS. Download it today!
|
|
|
|