Previous Thread
Next Thread
Print Thread
Page 149 of 536 1 2 147 148 149 150 151 535 536
Joined: Dec 1999
Posts: 1,178
Likes: 2
J
Very Senior Member
Offline
Very Senior Member
J
Joined: Dec 1999
Posts: 1,178
Likes: 2
Originally Posted By Spa8nky
Now that's hardcore. smile


That's just how our makefile rolls cool

Joined: Jul 2007
Posts: 4,625
A
Anna Wu Offline OP
Very Senior Member
OP Offline
Very Senior Member
A
Joined: Jul 2007
Posts: 4,625
Just a question :

Why the MESS program icon resource for Mess.exe was removed ?

Joined: Sep 2001
Posts: 534
F
Senior Member
Offline
Senior Member
F
Joined: Sep 2001
Posts: 534
When did this happen? I am not aware of doing anything with it and it was still there for me yesterday. Maybe a clean build necessary?

Joined: Jul 2007
Posts: 4,625
A
Anna Wu Offline OP
Very Senior Member
OP Offline
Very Senior Member
A
Joined: Jul 2007
Posts: 4,625
Originally Posted By Firewave
When did this happen? I am not aware of doing anything with it and it was still there for me yesterday. Maybe a clean build necessary?


SVN r8005

Also check bobz last build (SVN r8003). The icon is also missing in his build.
As I said, Im talking about Mess.exe (32-bit) and not MessUI.exe.

but I will make a clean compile again ...

Last edited by Anna Wu; 05/09/10 09:49 PM.
Joined: Aug 2009
Posts: 669
Senior Member
Offline
Senior Member
Joined: Aug 2009
Posts: 669
can confirm it here. Mess.exe has no icon.

Clean build. Win xp 32bit serv 3

Joined: Sep 2001
Posts: 534
F
Senior Member
Offline
Senior Member
F
Joined: Sep 2001
Posts: 534
Will take a look when I get back home tomorrow.

Joined: Jul 2007
Posts: 4,625
A
Anna Wu Offline OP
Very Senior Member
OP Offline
Very Senior Member
A
Joined: Jul 2007
Posts: 4,625
Originally Posted By Firewave
Will take a look when I get back home tomorrow.


A clean compile was not useful.
Added now following strings for my build (src\mess\osd\windows\mess.rc)

Code:
/////////////////////////////////////////////////////////////////////////////
//
// Icon
//

IDI_ICON_MESS           ICON    DISCARDABLE     "../../osd/winui/res/mess.ico"


so the program icon is back. smile

Last edited by Anna Wu; 05/10/10 06:28 AM.
Joined: Sep 2001
Posts: 534
F
Senior Member
Offline
Senior Member
F
Joined: Sep 2001
Posts: 534
Good catch Anna. It was caused by the device icon cleanup:

http://mess.dorando.at/svn/?rev=7912

I thought it would have complained about the missing ID. Added it back and credited you for the fix.

Joined: Aug 2004
Posts: 1,455
Likes: 9
Very Senior Member
Offline
Very Senior Member
Joined: Aug 2004
Posts: 1,455
Likes: 9
i wonder about the other stuff that was removed, it must have been there for a reason..

Joined: Sep 2001
Posts: 534
F
Senior Member
Offline
Senior Member
F
Joined: Sep 2001
Posts: 534
Originally Posted By robbbert
i wonder about the other stuff that was removed, it must have been there for a reason..


It were newui specific icons, that were supposed to be shown for the menu entries. But they were just read and never used and menus don't even support icons just bitmaps, so I removed it.

Page 149 of 536 1 2 147 148 149 150 151 535 536

Link Copied to Clipboard
Who's Online Now
3 members (Augusto, Heihachi_73, 1 invisible), 16 guests, and 3 robots.
Key: Admin, Global Mod, Mod
ShoutChat
Comment Guidelines: Do post respectful and insightful comments. Don't flame, hate, spam.
Forum Statistics
Forums9
Topics9,087
Posts119,098
Members5,014
Most Online890
Jan 17th, 2020
Our Sponsor
These forums are sponsored by Superior Solitaire, an ad-free card game collection for macOS and iOS. Download it today!

Superior Solitaire
Forum hosted by www.retrogamesformac.com